tools/syz-covermerger: fix misconfiguration #5601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
report_status_to_batch_job
branch
from
00f5724 to
979a2bf
Compare
I don't see any visible problems but the records in DB are not created. Let's report the amount of records created at the end of the batch step. +log the names of the managers
This config option is needed to collect details like manager name. In the following PRs I'll remove this option and make this behavior default.
tarasmadan
force-pushed
the
report_status_to_batch_job
branch
from
979a2bf to
af3e4b1
Compare
tarasmadan
changed the title
a-nogikh
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves logging to see how many records were added to the DB.
Fixes misconfiguration. Enabled extended information collection(including the manager name).
In the following commits I'll remove this config option and make it default behavior.